Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS 10.14 Mojave for x86_64 deployment #378

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

vincentsong
Copy link
Collaborator

No description provided.

@djova-dolby djova-dolby force-pushed the support-macOS-Mojave branch 3 times, most recently from a91a96b to 900e95a Compare March 23, 2024 15:18
- Windows runner has cmake 3.28
- It is not detecting properly escaped quotes around x64 arch
- Harcode it to make sure it works
- Lets see if this fixes the windows build
- This will autocancel new workflows if same branch is pushed with new/ammended commits
- This is workaround
- Download and use cmake 3.21 on Windows
- Elleviate these issues with 3.28 on these new windows machines
  - Like not finding ffmpeg
- This will be using x64 machines, but Xcode lets you cross-compile for both archs
- For webrtc/native-sdks we build everything on x64 machines
- I am not sure though if some of these deps installed or whatever except to be on arm64 system
  - Like how OBS build is configured and such and going into this would be waste of time now
- Thus if this doesn't work we will just fix the self hosted machine and thats it
- We now use cmake 3.21 which should fix this

This reverts commit a179e45.
@djova-dolby djova-dolby force-pushed the support-macOS-Mojave branch from 6379f1f to a9f14aa Compare March 25, 2024 09:28
@djova-dolby djova-dolby merged commit a9f14aa into m112-v28.1.2 Mar 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants